linux-kernel - Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Apr 2021 08:19:44 +0800
From:   Kevin Tang <kevin3.tang@...il.com>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

Maxime Ripard <maxime@...no.tech> 于2021年4月7日周三 下午6:48写道：
>
> On Wed, Mar 31, 2021 at 09:47:12AM +0800, Kevin Tang wrote:
> > > > diff --git a/drivers/gpu/drm/sprd/Makefile
> > > b/drivers/gpu/drm/sprd/Makefile
> > > > index 6c25bfa99..d49f4977b 100644
> > > > --- a/drivers/gpu/drm/sprd/Makefile
> > > > +++ b/drivers/gpu/drm/sprd/Makefile
> > > > @@ -1,5 +1,8 @@
> > > >  # SPDX-License-Identifier: GPL-2.0
> > > >
> > > >  obj-y := sprd_drm.o \
> > > > -     sprd_dpu.o
> > > > -
> > > > +     sprd_dpu.o \
> > > > +     sprd_dsi.o \
> > > > +     dw_dsi_ctrl.o \
> > > > +     dw_dsi_ctrl_ppi.o \
> > >
> > > So it's a designware IP? There's a driver for it already that seems
> > > fairly similar:
> > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > >
> > Our dw dsi controller is not a standard synopsys ip, we have updated a lot
> > on the basic ip version,
> > the entire control register is different, i have cc to drm/bridge reviewers
> > and maintainers.
>
> You should make it more obvious then in a comment or in the name of the
> driver. If it's fairly different from the original IP from Synopsys,
> maybe you should just drop the reference to the name?
Thks, i will be fix it.
>
> Maxime