linux-kernel - Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <896527ac-0e94-b930-80ec-8c7ef669b149@linaro.org>
Date:   Thu, 15 Apr 2021 10:34:21 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     zhuguangqing83@...il.com,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only
 threaded handler



On 15/04/2021 08:38, zhuguangqing83@...il.com wrote:
> From: Guangqing Zhu <zhuguangqing83@...il.com>
> 
> Coccinelle noticed:
>    sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
> 
> Signed-off-by: Guangqing Zhu <zhuguangqing83@...il.com>
> ---

Thanks for the patch,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

>   sound/soc/codecs/wcd934x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
> index 5fe403307b72..cddc49bbb7f6 100644
> --- a/sound/soc/codecs/wcd934x.c
> +++ b/sound/soc/codecs/wcd934x.c
> @@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)
>   
>   	ret = devm_request_threaded_irq(dev, irq, NULL,
>   					wcd934x_slim_irq_handler,
> -					IRQF_TRIGGER_RISING,
> +					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
>   					"slim", wcd);
>   	if (ret) {
>   		dev_err(dev, "Failed to request slimbus irq\n");
>