linux-kernel - Re: [PATCH 48/57] staging: comedi: drivers: jr3_pci: Remove set but unused variable 'min_full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210415095249.GW4869@dell>
Date:   Thu, 15 Apr 2021 10:52:49 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Ian Abbott <abbotti@....co.uk>
Cc:     linux-kernel@...r.kernel.org,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Anders Blomdell <anders.blomdell@...trol.lth.se>,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH 48/57] staging: comedi: drivers: jr3_pci: Remove set but
 unused variable 'min_full_scale'

On Thu, 15 Apr 2021, Ian Abbott wrote:

> On 14/04/2021 19:11, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >   drivers/staging/comedi/drivers/jr3_pci.c: In function ‘jr3_pci_poll_subdevice’:
> >   drivers/staging/comedi/drivers/jr3_pci.c:507:22: warning: variable ‘min_full_scale’ set but not used [-Wunused-but-set-variable]
> > 
> > Cc: Ian Abbott <abbotti@....co.uk>
> > Cc: H Hartley Sweeten <hsweeten@...ionengravers.com>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: "Alexander A. Klimov" <grandmaster@...klimov.de>
> > Cc: Anders Blomdell <anders.blomdell@...trol.lth.se>
> > Cc: linux-staging@...ts.linux.dev
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >   drivers/staging/comedi/drivers/jr3_pci.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> > index 7a02c4fa3cda8..afa2f8d5c8c0c 100644
> > --- a/drivers/staging/comedi/drivers/jr3_pci.c
> > +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> > @@ -504,10 +504,9 @@ jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> >   			result = poll_delay_min_max(20, 100);
> >   		} else {
> >   			/* Set full scale */
> > -			struct six_axis_t min_full_scale;
> >   			struct six_axis_t max_full_scale;
> > -			min_full_scale = get_min_full_scales(sensor);
> > +			get_min_full_scales(sensor);
> >   			max_full_scale = get_max_full_scales(sensor);
> >   			set_full_scales(sensor, max_full_scale);
> > 
> 
> get_min_full_scales() could be removed altogether.  It was only being called
> originally so the driver could printk the values, but those printks have
> since been removed.

Even better.  Thanks Ian.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog