linux-kernel - Re: [PATCH] memstick: r592: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFr_Rnds6=W-TpOMhVcO9aP9OLapqCy1rFp8EHriWuQbuw@mail.gmail.com>
Date:   Thu, 15 Apr 2021 14:02:29 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     Maxim Levitsky <maximlevitsky@...il.com>,
        Alex Dubov <oakad@...oo.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memstick: r592: remove unused variable

On Wed, 14 Apr 2021 at 04:21, Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Fix the following clang warning:
>
> drivers/memstick/host/r592.c:363:6: warning: variable ‘len’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/memstick/host/r592.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> index d2ef463..026fada 100644
> --- a/drivers/memstick/host/r592.c
> +++ b/drivers/memstick/host/r592.c
> @@ -360,12 +360,11 @@ static void r592_write_fifo_pio(struct r592_device *dev,
>  static void r592_flush_fifo_write(struct r592_device *dev)
>  {
>         u8 buffer[4] = { 0 };
> -       int len;
>
>         if (kfifo_is_empty(&dev->pio_fifo))
>                 return;
>
> -       len = kfifo_out(&dev->pio_fifo, buffer, 4);
> +       kfifo_out(&dev->pio_fifo, buffer, 4);
>         r592_write_reg_raw_be(dev, R592_FIFO_PIO, *(u32 *)buffer);
>  }
>
> --
> 1.8.3.1
>