linux-kernel - RE: [PATCH 1/5] xattr: Complete constify ->name member of "struct xattr"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eedc6f82d59b4084b529788efd43e10b@huawei.com>
Date:   Thu, 15 Apr 2021 12:25:49 +0000
From:   Roberto Sassu <roberto.sassu@...wei.com>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Jeff Mahoney <jeffm@...e.com>
CC:     "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "selinux@...r.kernel.org" <selinux@...r.kernel.org>,
        "reiserfs-devel@...r.kernel.org" <reiserfs-devel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "zohar@...ux.ibm.com" <zohar@...ux.ibm.com>,
        "jmorris@...ei.org" <jmorris@...ei.org>,
        "paul@...l-moore.com" <paul@...l-moore.com>,
        "casey@...aufler-ca.com" <casey@...aufler-ca.com>
Subject: RE: [PATCH 1/5] xattr: Complete constify ->name member of "struct
 xattr"

> From: Tetsuo Handa [mailto:penguin-kernel@...ove.sakura.ne.jp]
> Sent: Thursday, April 15, 2021 1:20 PM
> On 2021/04/15 19:04, Roberto Sassu wrote:
> > This patch completes commit 9548906b2bb7 ('xattr: Constify ->name
> member of
> > "struct xattr"'). It fixes the documentation of the inode_init_security
> > hook, by removing the xattr name from the objects that are expected to
> be
> > allocated by LSMs (only the value is allocated). Also, it removes the
> > kfree() of name and setting it to NULL in the reiserfs code.
> 
> Good catch, but well, grep does not find any reiserfs_security_free() callers.
> Is reiserfs_security_free() a dead code?

Uhm, I also don't see it.

Thanks

Roberto

HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Li Jian, Shi Yanli