linux-kernel - Re: [PATCH] nfsd: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B0507BAA-EF6E-4A88-8799-9624DCF58C7F@oracle.com>
Date:   Thu, 15 Apr 2021 14:12:02 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     Bruce Fields <bfields@...ldses.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfsd: remove unused function



> On Apr 15, 2021, at 4:38 AM, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
> 
> Fix the following clang warning:
> 
> fs/nfsd/nfs4state.c:6276:1: warning: unused function 'end_offset'
> [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Thanks for your patch. It's been added to the for-next topic branch in

git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


> ---
> fs/nfsd/nfs4state.c | 9 ---------
> 1 file changed, 9 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 97447a6..32b11ff 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -6272,15 +6272,6 @@ static void nfsd4_close_open_stateid(struct nfs4_ol_stateid *s)
> 	return status;
> }
> 
> -static inline u64
> -end_offset(u64 start, u64 len)
> -{
> -	u64 end;
> -
> -	end = start + len;
> -	return end >= start ? end: NFS4_MAX_UINT64;
> -}
> -
> /* last octet in a range */
> static inline u64
> last_byte_offset(u64 start, u64 len)
> -- 
> 1.8.3.1
> 

--
Chuck Lever