linux-kernel - Re: [PATCH] mtd: core: Constify buf in mtd_write_user_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210416203336.388878ad@xps13>
Date:   Fri, 16 Apr 2021 20:33:36 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Tudor Ambarus <tudor.ambarus@...rochip.com>
Cc:     <richard@....at>, <vigneshr@...com>, <kyungmin.park@...sung.com>,
        <michael@...le.cc>, <p.yadav@...com>, <jean-philippe@...aro.org>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: core: Constify buf in mtd_write_user_prot_reg()

Hi Tudor,

Tudor Ambarus <tudor.ambarus@...rochip.com> wrote on Sat, 3 Apr 2021
09:09:31 +0300:

> The write buffer comes from user and should be const.
> Constify write buffer in mtd core and across all _write_user_prot_reg()
> users. cfi_cmdset_{0001, 0002} and onenand_base will pay the cost of an
> explicit cast to discard the const qualifier since the beginning, since
> they are using an otp_op_t function prototype that is used for both reads
> and writes. mtd_dataflash and SPI NOR will benefit of the const buffer
> because they are using different paths for writes and reads.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

Applied on top of mtd/next after the merge of all our internal PR's.

Thanks,
Miquèl