linux-kernel - Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <161861118020.865088.6364463756780633947.b4-ty@bootlin.com>
Date:   Sat, 17 Apr 2021 00:16:40 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Francois Gervais <fgervais@...tech-controls.com>,
        linux-rtc@...r.kernel.org
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Michael McCormick <michael.mccormick@...tel.net>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node

On Wed, 10 Mar 2021 16:10:26 -0500, Francois Gervais wrote:
> The rtc device node is always or at the very least can possibly be NULL.
> 
> Since v5.12-rc1-dontuse/3c9ea42802a1fbf7ef29660ff8c6e526c58114f6 this
> will lead to a NULL pointer dereference.
> 
> To fix this we fallback to using the parent node which is the i2c client
> node as set by devm_rtc_allocate_device().
> 
> [...]

Applied, thanks!

[1/1] rtc: pcf85063: fallback to parent of_node
      commit: 03531606ef4cda25b629f500d1ffb6173b805c05

I made the fallback unconditionnal because this should have been that way from
the beginning as you point out.

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@...tlin.com>