| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Apr 2021 09:31:11 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@...il.com>
Cc: Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
ac100@...ts.launchpad.net,
"Alexander A. Klimov" <grandmaster@...klimov.de>,
Allen Pais <apais@...ux.microsoft.com>,
Anders Blomdell <anders.blomdell@...trol.lth.se>,
Andrea Merello <andrea.merello@...il.com>,
Andres Klode <jak@...-linux.org>,
Andrey Shvetsov <andrey.shvetsov@....de>,
Arve Hjønnevåg <arve@...roid.com>,
Christian Brauner <christian@...uner.io>,
Comedi <comedi@...edi.org>, "David A. Schleef" <ds@...leef.org>,
dri-devel@...ts.freedesktop.org,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Forest Bond <forest@...ttletooquiet.net>,
Herman.Bruyninckx@...h.kuleuven.ac.be,
H Hartley Sweeten <hsweeten@...ionengravers.com>,
Hridya Valsaraju <hridya@...gle.com>,
Ian Abbott <abbotti@....co.uk>,
Ilya Petrov <ilya.muromec@...il.com>,
Jacob Feder <jacobsfeder@...il.com>,
Jerry chuang <wlanfae@...ltek.com>,
Joel Fernandes <joel@...lfernandes.org>,
"John B. Wyatt IV" <jbwyatt4@...il.com>,
Jonathan Cameron <jic23@...nel.org>,
"J.P. Mellor" <jpmellor@...e-hulman.edu>,
karthik alapati <mail@...thek.com>,
Kees Cook <keescook@...omium.org>,
Kernel Team <ac100@...ts.lauchpad.net>,
Klaas.Gadeyne@...h.kuleuven.ac.be,
Larry Finger <Larry.Finger@...inger.net>,
Lars-Peter Clausen <lars@...afoo.de>,
linux-fbdev@...r.kernel.org, linux-iio@...r.kernel.org,
linux-pwm@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-tegra@...r.kernel.org, Marc Dietrich <marvin24@....de>,
Marco Cesati <marcocesati@...il.com>,
Martijn Coenen <maco@...roid.com>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Michael Straube <straube.linux@...il.com>,
Mori Hess <fmhess@...rs.sourceforge.net>,
Nícolas F. R. A. Prado
<nfraprado@...tonmail.com>,
Peter Hurley <peter@...leysoftware.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Pierre-Hugues Husson <phhusson@...e.fr>,
Robert Love <rlove@...gle.com>,
Romain Perier <romain.perier@...il.com>,
Ross Schmidt <ross.schm.dev@...il.com>,
"Spencer E. Olson" <olsonse@...ch.edu>, Stanley@...sd3,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Sumera Priyadarsini <sylphrenadin@...il.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Teddy Wang <teddy.wang@...iconmotion.com>,
Thierry Reding <thierry.reding@...il.com>,
Thomas Gleixner <tglx@...utronix.de>,
Todd Kjos <tkjos@...roid.com>,
Truxton Fulton <trux@...xton.com>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Wim.Meeussen@...h.kuleuven.ac.be,
Zhansaya Bagdauletkyzy <zhansayabagdaulet@...il.com>
Subject: Re: [PATCH 00/57] Rid W=1 warnings from Staging
On Fri, Apr 16, 2021 at 09:27:51AM +0200, Fabio Aiuto wrote:
> On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (57):
> > staging: r8192U_core: Remove two unused variables 'ret' and
> > 'reset_status'
> > staging: android: ashmem: Supply description for 'new_range'
> > staging: comedi_8254: Fix descriptions for 'i8254' and 'iobase'
> > staging: r8192U_core: Do not use kernel-doc formatting for !kernel-doc
> > headers
> > staging: r819xU_phy: Remove some local variables from the stack
> > staging: r819xU_cmdpkt: Remove functionless method
> > 'cmpk_handle_query_config_rx'
> > staging: wlan-ng: cfg80211: Move large struct onto the heap
> > staging: rtw_ioctl_set: Move 'channel_table' to the only place it's
> > used
> > staging: rtl8188eu: core: rtw_ieee80211: Fix incorrectly documented
> > function
> > staging: rtl8723bs: core: rtw_mlme: Remove a bunch of unused variables
> > staging: rtl8723bs: core: rtw_mlme_ext: Deal with a bunch of unused
> > variables
> > staging: rtl8712: rtl871x_mp_ioctl: Remove a bunch of unused tables
> > staging: rtl8723bs: core: rtw_recv: Mark debug variable as
> > __maybe_unused
> > staging: rtl8188eu: core: rtw_security: Fix some formatting and
> > misdocumentation
> > staging: rtl8723bs: core: rtw_security: Demote non-conformant
> > kernel-doc header
> > staging: rtl8723bs: core: rtw_sta_mgt: Remove unused variable 'psta'
> > staging: rtl8723bs: core: rtw_sta_mgt: Return error value directly
> > staging: octeon: ethernet-tx: Fix formatting issue in function header
> > staging: rtl8723bs: core: rtw_wlan_util: Remove unused variable
> > 'start_seq'
> > staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the
> > heap
> > staging: iio: frequency: ad9834: Provide missing description for
> > 'devid'
> > staging: nvec: Fix a bunch of kernel-doc issues
> > staging: ks7010: ks_hostif: Remove a bunch of unused variables
> > staging: fwserial: Demote a whole host of kernel-doc abuses
> > staging: sm750fb: sm750_accel: Provide description for 'accel' and fix
> > function naming
> > staging: most: net: Fix some kernel-doc formatting issues
> > staging: vt6655: upc: Suppress set but not used warning in macro
> > staging: rtl8192u: ieee80211_softmac: Move a large data struct onto
> > the heap
> > staging: most: dim2: Provide missing descriptions and fix doc-rot
> > staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless
> > copy
> > staging: rtl8723bs: core: rtw_mlme: 'retry' is only used if REJOIN is
> > set
> > staging: rtl8723bs: core: rtw_mlme_ext: 'evt_seq' is only used if
> > CHECK_EVENT_SEQ is set
> > staging: most: i2c: Fix a little doc-rot
> > staging: most: dim2: hal: Fix one kernel-doc header and demote two
> > non-conforming ones
> > staging: most: dim2: hal: Demote non-conformant kernel-doc headers
> > staging: axis-fifo: axis-fifo: Fix some formatting issues
> > staging: rtl8188eu: os_dep: ioctl_linux: Move 2 large data buffers
> > into the heap
> > staging: fbtft: fb_ili9320: Remove unused variable 'ret'
> > staging: rtl8723bs: core: rtw_ieee80211: Fix incorrectly named
> > function
> > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable and
> > dead code
> > staging: rtl8188eu: os_dep: mon: Demote non-conforming kernel-doc
> > headers
> > staging: rtl8188eu: os_dep: rtw_android: Demote kernel-doc abuse
> > staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and
> > dead code
> > staging: rtl8723bs: hal: rtl8723b_phycfg: Fix a bunch of misnamed
> > functions
> > staging: rtl8723bs: hal: sdio_halinit: 'start' is only used if debug
> > is enabled
> > staging: rtl8723bs: hal: sdio_ops: Mark used 'err' as __maybe_unused
> > and remove another
> > staging: rtl8723bs: os_dep: ioctl_cfg80211: 'ack' is used when debug
> > is enabled
> > staging: comedi: drivers: jr3_pci: Remove set but unused variable
> > 'min_full_scale'
> > staging: comedi: drivers: ni_tio: Fix slightly broken kernel-doc and
> > demote others
> > staging: comedi: drivers: ni_routes: Demote non-conforming kernel-doc
> > headers
> > staging: axis-fifo: axis-fifo: Fix function naming in the
> > documentation
> > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable
> > 'func_start'
> > staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer
> > onto the heap
> > staging: rtl8723bs: hal: rtl8723b_hal_init: Mark a bunch of debug
> > variables as __maybe_unused
> > staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to
> > where it is used
> > staging: comedi: drivers: comedi_isadma: Fix misspelling of
> > 'dma_chan1'
> > staging: rtl8723bs: hal: sdio_halinit: Remove unused variable 'ret'
> >
> > drivers/staging/android/ashmem.c | 1 +
> > drivers/staging/axis-fifo/axis-fifo.c | 18 +--
> > drivers/staging/comedi/drivers/comedi_8254.c | 3 +-
> > .../staging/comedi/drivers/comedi_isadma.c | 2 +-
> > drivers/staging/comedi/drivers/jr3_pci.c | 3 +-
> > .../staging/comedi/drivers/ni_mio_common.c | 9 --
> > drivers/staging/comedi/drivers/ni_routes.c | 6 +-
> > drivers/staging/comedi/drivers/ni_stc.h | 9 +-
> > drivers/staging/comedi/drivers/ni_tio.c | 12 +-
> > drivers/staging/fbtft/fb_ili9320.c | 3 +-
> > drivers/staging/fwserial/fwserial.c | 46 +++----
> > drivers/staging/iio/frequency/ad9834.c | 5 +-
> > drivers/staging/ks7010/ks_hostif.c | 14 +-
> > drivers/staging/most/dim2/dim2.c | 23 ++--
> > drivers/staging/most/dim2/hal.c | 10 +-
> > drivers/staging/most/i2c/i2c.c | 12 +-
> > drivers/staging/most/net/net.c | 6 +-
> > drivers/staging/nvec/nvec.c | 7 +-
> > drivers/staging/octeon/ethernet-tx.c | 1 -
> > drivers/staging/qlge/qlge_main.c | 4 +-
> > .../staging/rtl8188eu/core/rtw_ieee80211.c | 2 +-
> > .../staging/rtl8188eu/core/rtw_ioctl_set.c | 8 ++
> > drivers/staging/rtl8188eu/core/rtw_security.c | 10 +-
> > .../staging/rtl8188eu/include/rtw_mlme_ext.h | 8 --
> > .../staging/rtl8188eu/os_dep/ioctl_linux.c | 12 +-
> > drivers/staging/rtl8188eu/os_dep/mon.c | 6 +-
> > .../staging/rtl8188eu/os_dep/rtw_android.c | 2 +-
> > .../rtl8192u/ieee80211/ieee80211_softmac.c | 9 +-
> > drivers/staging/rtl8192u/r8192U_core.c | 11 +-
> > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 41 ------
> > drivers/staging/rtl8192u/r819xU_phy.c | 48 +++++--
> > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 29 ++--
> > drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 127 ------------------
> > .../staging/rtl8723bs/core/rtw_ieee80211.c | 6 +-
> > drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 +--
> > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 19 +--
> > drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
> > drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
> > drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 10 +-
> > .../staging/rtl8723bs/core/rtw_wlan_util.c | 4 +-
> > .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 9 +-
> > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 21 +--
> > .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 10 +-
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 +-
> > drivers/staging/rtl8723bs/hal/sdio_ops.c | 7 +-
> > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
> > drivers/staging/sm750fb/sm750_accel.c | 4 +-
> > drivers/staging/vt6655/upc.h | 2 +-
> > drivers/staging/wlan-ng/cfg80211.c | 30 +++--
> > 49 files changed, 256 insertions(+), 404 deletions(-)
> >
> > Cc: ac100@...ts.launchpad.net
> > Cc: "Alexander A. Klimov" <grandmaster@...klimov.de>
> > Cc: Allen Pais <apais@...ux.microsoft.com>
> > Cc: Anders Blomdell <anders.blomdell@...trol.lth.se>
> > Cc: Andrea Merello <andrea.merello@...il.com>
> > Cc: Andres Klode <jak@...-linux.org>
> > Cc: Andrey Shvetsov <andrey.shvetsov@....de>
> > Cc: "Arve Hjønnevåg" <arve@...roid.com>
> > Cc: Christian Brauner <christian@...uner.io>
> > Cc: Comedi <comedi@...edi.org>
> > Cc: "David A. Schleef" <ds@...leef.org>
> > Cc: dri-devel@...ts.freedesktop.org
> > Cc: Fabio Aiuto <fabioaiuto83@...il.com>
> > Cc: Florian Schilhabel <florian.c.schilhabel@...glemail.com>
> > Cc: Forest Bond <forest@...ttletooquiet.net>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Herman.Bruyninckx@...h.kuleuven.ac.be
> > Cc: H Hartley Sweeten <hsweeten@...ionengravers.com>
> > Cc: Hridya Valsaraju <hridya@...gle.com>
> > Cc: Ian Abbott <abbotti@....co.uk>
> > Cc: Ilya Petrov <ilya.muromec@...il.com>
> > Cc: Jacob Feder <jacobsfeder@...il.com>
> > Cc: Jerry chuang <wlanfae@...ltek.com>
> > Cc: Joel Fernandes <joel@...lfernandes.org>
> > Cc: "John B. Wyatt IV" <jbwyatt4@...il.com>
> > Cc: Jonathan Cameron <jic23@...nel.org>
> > Cc: "J.P. Mellor" <jpmellor@...e-hulman.edu>
> > Cc: karthik alapati <mail@...thek.com>
> > Cc: Kees Cook <keescook@...omium.org>
> > Cc: Kernel Team <ac100@...ts.lauchpad.net>
> > Cc: Klaas.Gadeyne@...h.kuleuven.ac.be
> > Cc: Larry Finger <Larry.Finger@...inger.net>
> > Cc: Lars-Peter Clausen <lars@...afoo.de>
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Cc: linux-fbdev@...r.kernel.org
> > Cc: linux-iio@...r.kernel.org
> > Cc: linux-pwm@...r.kernel.org
> > Cc: linux-staging@...ts.linux.dev
> > Cc: linux-tegra@...r.kernel.org
> > Cc: Marc Dietrich <marvin24@....de>
> > Cc: Marco Cesati <marcocesati@...il.com>
> > Cc: Martijn Coenen <maco@...roid.com>
> > Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> > Cc: Michael Straube <straube.linux@...il.com>
> > Cc: Mori Hess <fmhess@...rs.sourceforge.net>
> > Cc: "Nícolas F. R. A. Prado" <nfraprado@...tonmail.com>
> > Cc: Peter Hurley <peter@...leysoftware.com>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Cc: Pierre-Hugues Husson <phhusson@...e.fr>
> > Cc: Robert Love <rlove@...gle.com>
> > Cc: Romain Perier <romain.perier@...il.com>
> > Cc: Ross Schmidt <ross.schm.dev@...il.com>
> > Cc: "Spencer E. Olson" <olsonse@...ch.edu>
> > Cc: Stanley@...SD3
> > Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> > Cc: Sumera Priyadarsini <sylphrenadin@...il.com>
> > Cc: Suren Baghdasaryan <surenb@...gle.com>
> > Cc: Teddy Wang <teddy.wang@...iconmotion.com>
> > Cc: Thierry Reding <thierry.reding@...il.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Todd Kjos <tkjos@...roid.com>
> > Cc: Truxton Fulton <trux@...xton.com>
> > Cc: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> > Cc: Wim.Meeussen@...h.kuleuven.ac.be
> > Cc: WLAN FAE <wlanfae@...ltek.com>
> > Cc: Zhansaya Bagdauletkyzy <zhansayabagdaulet@...il.com>
> > --
> > 2.27.0
> >
>
> Hi,
>
> what about splitting this series in smaller per driver series?
No real need to, I can handle patch series this big easily.
thanks,
greg k-h
Powered by blists - more mailing lists