linux-kernel - Re: [PATCH] regulator: mt6360: Fix missing IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPe+eK-2cZ2h-WUUrfPwkXrHGopaEmx0Kwjsa4Nqq0DyeA@mail.gmail.com>
Date:   Fri, 16 Apr 2021 10:45:33 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     zhuguangqing83@...il.com
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only
 threaded handler

On Fri, 16 Apr 2021 at 06:30, <zhuguangqing83@...il.com> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@...il.com>
>
> Coccinelle noticed:
> drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT

This should be tested. There are several patches like this all over
the tree so it looks like "let's fix everything from Coccinelle"
because you ignored at least in some of the cases that the handler is
not the primary one. I am not saying that the change is bad, but
rather it looks automated.

Best regards,
Krzysztof