linux-kernel - Re: [PATCH] irq: Fix missing IRQF_ONESHOT as only threaded handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPf=X+EQJXSFAsuC54Fwvi4TNX9JAoYsEUp7j3BKio4gQQ@mail.gmail.com>
Date:   Fri, 16 Apr 2021 10:49:09 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     zhuguangqing83@...il.com
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irq: Fix missing IRQF_ONESHOT as only threaded handler

On Tue, 13 Apr 2021 at 15:42, <zhuguangqing83@...il.com> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@...il.com>
>
> Coccinelle noticed:
>   kernel/irq/manage.c:2199:8-28: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT.
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@...il.com>
> ---
>  kernel/irq/manage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 4c14356543d9..222816750048 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2197,7 +2197,7 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,
>
>         if (irq_settings_is_nested_thread(desc)) {
>                 ret = request_threaded_irq(irq, NULL, handler,
> -                                          flags, name, dev_id);
> +                                          flags | IRQF_ONESHOT, name, dev_id);

This is a core IRQ code... and you clearly see here a nested IRQ.
Please, stop sending automated coccinelle patches.

Best regards,
Krzysztof