linux-kernel - Re: [PATCH] ALSA: isa: Fix inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hmttyqzsg.wl-tiwai@suse.de>
Date:   Fri, 16 Apr 2021 12:39:11 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: isa: Fix inconsistent indenting

On Fri, 16 Apr 2021 11:59:58 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
> inconsistent indenting
> sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
> inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  sound/isa/opti9xx/opti92x-ad1848.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
> index 08e61d9..234f023 100644
> --- a/sound/isa/opti9xx/opti92x-ad1848.c
> +++ b/sound/isa/opti9xx/opti92x-ad1848.c
> @@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip,
>  		chip->mc_base_size = opti9xx_mc_size[hardware];
>  	}
>  #else
> -		chip->mc_base_size = opti9xx_mc_size[hardware];
> +	chip->mc_base_size = opti9xx_mc_size[hardware];
>  #endif

No, it's not correct.

The ifdef is a bit tricky here but the line you changed belongs
to the else section.


thanks,

Takashi