linux-kernel - Re: [PATCH v1 1/2] coresight: Add support for device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87im4mfpds.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Fri, 16 Apr 2021 14:19:27 +0300
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Tao Zhang <taozha@...eaurora.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>
Cc:     Tao Zhang <taozha@...eaurora.org>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Tingwei Zhang <tingwei@...eaurora.org>,
        Mao Jinlong <jinlmao@...eaurora.org>,
        Yuanfang Zhang <zhangyuanfang@...eaurora.org>,
        alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v1 1/2] coresight: Add support for device names

Tao Zhang <taozha@...eaurora.org> writes:

> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 4ba801d..b79c726 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1640,6 +1640,12 @@ char *coresight_alloc_device_name(struct coresight_dev_list *dict,
>  	int idx;
>  	char *name = NULL;
>  	struct fwnode_handle **list;
> +	struct device_node *node = dev->of_node;
> +
> +	if (!node) {
> +		if (!of_property_read_string(node, "coresight-name", &name))

Ok, I'm not a device tree expert, but I'm pretty sure the above is a
nop.

Regards,
--
Alex