linux-kernel - Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210416113326.GO16633@gondor.apana.org.au>
Date:   Fri, 16 Apr 2021 21:33:26 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Hui Tang <tanghui20@...wei.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        xuzaibo@...wei.com, wangzhou1@...ilicon.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and
 return in advance

On Sat, Apr 10, 2021 at 05:50:32PM +0800, Hui Tang wrote:
> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
> necessary to do it here, so remove it.
> 
> It should return error immediately when return value of 'hpre_cfg_by_dsm'
> is non-zero, and no need to execute the remaining sentences.
> 
> Signed-off-by: Hui Tang <tanghui20@...wei.com>
> 
> ---
> v1 -> v2:
>    - Return immediately when return value of 'hpre_cfg_by_dsm' is
>      non-zero.
> v2 -> v3:
>    - Add description for return if function fails.
> ---
>  drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt