linux-kernel - [PATCH] drivers: ipa: Fix missing IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Apr 2021 11:40:07 +0800
From:   zhuguangqing83@...il.com
To:     Alex Elder <elder@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guangqing Zhu <zhuguangqing83@...il.com>
Subject: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler

From: Guangqing Zhu <zhuguangqing83@...il.com>

Coccinelle noticed:
drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT

Signed-off-by: Guangqing Zhu <zhuguangqing83@...il.com>
---
 drivers/net/ipa/ipa_smp2p.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
index a5f7a79a1923..74e04427a711 100644
--- a/drivers/net/ipa/ipa_smp2p.c
+++ b/drivers/net/ipa/ipa_smp2p.c
@@ -183,7 +183,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
 	}
 	irq = ret;
 
-	ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p);
+	ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT,
+				   name, smp2p);
 	if (ret) {
 		dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name);
 		return ret;
-- 
2.17.1