linux-kernel - Re: [PATCH] scsi: a100u2w: remove useless variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Apr 2021 16:34:54 +1000
From:   Julian Calaby <julian.calaby@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: a100u2w: remove useless variable

Hi Jiapeng,

On Mon, Apr 12, 2021 at 1:23 PM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Fix the following gcc warning:
>
> drivers/scsi/a100u2w.c:1092:8: warning: variable ‘bios_phys’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/scsi/a100u2w.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
> index 66c5143..855a3fe 100644
> --- a/drivers/scsi/a100u2w.c
> +++ b/drivers/scsi/a100u2w.c
> @@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
>         int error = -ENODEV;
>         u32 sz;
>         unsigned long biosaddr;
> -       char *bios_phys;
>
>         if (pci_enable_device(pdev))
>                 goto out;
> @@ -1141,7 +1140,7 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
>         biosaddr = host->BIOScfg;
>         biosaddr = (biosaddr << 4);
> -       bios_phys = phys_to_virt(biosaddr);
> +       phys_to_virt(biosaddr);

Does phys_to_virt() have side effects? If it doesn't, there's a lot
more stuff that can get deleted here.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/