linux-kernel - Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 17 Apr 2021 11:37:01 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Dario Binacchi <dariobin@...ero.it>
Cc:     Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bin Meng <bmeng.cn@...il.com>,
        Frank Rowand <frowand.list@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
        linux-clk <linux-clk@...r.kernel.org>,
        linux-omap <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>

* Dario Binacchi <dariobin@...ero.it> [210414 20:40]:
> > Il 12/04/2021 09:41 Tero Kristo <kristo@...nel.org> ha scritto:
> > The change on the DT itself would be pretty large, removing all clock 
> > nodes and modifying any existing handles towards the clock nodes, and 
> > this would impact all OMAP architectures.
> > 
> > Anyways, it is mostly up-to Tony how he wants to see the DT change, as 
> > he is the maintainer for the OMAP family DT data.

While I think all the clocks should use a similar binding to the clkctrl
binding, I don't know if it makes sense to start changing things around
at such a large scale.

Certainly if somebody does the patches and they can be tested to not cause
regressions, sure why not :)

> > I am just raising the opinion here that from kernel point of view, 
> > adding the missing size cells seems unnecessary, and I can't see why 
> > u-boot can't be changed to support the existing broken DT. It is broken 
> > now, and it will be broken with the addition of the size cells in place, 
> > and the actual "neat" end result would be to get rid of the clock nodes 
> > completely.
> 
> I'll fix U-boot.
> Thanks for your explanations.
> Hope for SSC patch review from you and/or some TI MAINTAINER.

Best to fix the issues first, then make any clean-up patches a separate
series.

Regards,

Tony