linux-kernel - Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnt1s2lj.wl-maz@kernel.org>
Date:   Sat, 17 Apr 2021 10:05:28 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Zenghui Yu <yuzenghui@...wei.com>
Cc:     <netdev@...r.kernel.org>, <yangbo.lu@....com>,
        <john.stultz@...aro.org>, <tglx@...utronix.de>,
        <pbonzini@...hat.com>, <seanjc@...gle.com>,
        <richardcochran@...il.com>, <Mark.Rutland@....com>,
        <will@...nel.org>, <suzuki.poulose@....com>,
        <Andre.Przywara@....com>, <steven.price@....com>,
        <lorenzo.pieralisi@....com>, <sudeep.holla@....com>,
        <justin.he@....com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-team@...roid.com>,
        <kvmarm@...ts.cs.columbia.edu>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

On Sat, 17 Apr 2021 09:42:37 +0100,
Zenghui Yu <yuzenghui@...wei.com> wrote:
> 
> On 2021/3/30 22:54, Marc Zyngier wrote:
> > +int kvm_arch_ptp_init(void)
> > +{
> > +	int ret;
> > +
> > +	ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP);
> > +	if (ret <= 0)
> 
> kvm_arm_hyp_service_available() returns boolean. Maybe write as ?
> 
> 	bool ret;
> 
> 	ret = kvm_arm_hyp_service_available();
> 	if (!ret)
> 		return -ENODEV;

Fixed in 300bb1fe7671, as previously reported by Dan Carpenter in [1].

Thanks,

	M.

https://lore.kernel.org/r/20210331043704.GG2065@kadam

-- 
Without deviation from the norm, progress is not possible.