lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202104172338.SG4uwR1b-lkp@intel.com>
Date:   Sat, 17 Apr 2021 23:11:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Aravind Ramesh <aravind.ramesh@....com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, Jaegeuk Kim <jaegeuk@...nel.org>,
        Damien Le Moal <damien.lemoal@....com>,
        Niklas Cassel <niklas.cassel@....com>,
        Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>
Subject: fs/f2fs/super.c:3266:12: warning: stack frame size of 2192 bytes in
 function 'f2fs_scan_devices'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9cdbf6467424045617cd6e79dcaad06bb8efa31c
commit: de881df97768d07b342cbd1f8359b832afccace9 f2fs: support zone capacity less than zone size
date:   7 months ago
config: powerpc-randconfig-r011-20210417 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f549176ad976caa3e19edd036df9a7e12770af7c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=de881df97768d07b342cbd1f8359b832afccace9
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout de881df97768d07b342cbd1f8359b832afccace9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:193:1: note: expanded from here
   __do_insw
   ^
   arch/powerpc/include/asm/io.h:542:56: note: expanded from macro '__do_insw'
   #define __do_insw(p, b, n)      readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from fs/f2fs/super.c:12:
   In file included from include/linux/buffer_head.h:14:
   In file included from include/linux/pagemap.h:11:
   In file included from include/linux/highmem.h:10:
   In file included from include/linux/hardirq.h:10:
   In file included from arch/powerpc/include/asm/hardirq.h:6:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:195:1: note: expanded from here
   __do_insl
   ^
   arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insl'
   #define __do_insl(p, b, n)      readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from fs/f2fs/super.c:12:
   In file included from include/linux/buffer_head.h:14:
   In file included from include/linux/pagemap.h:11:
   In file included from include/linux/highmem.h:10:
   In file included from include/linux/hardirq.h:10:
   In file included from arch/powerpc/include/asm/hardirq.h:6:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:197:1: note: expanded from here
   __do_outsb
   ^
   arch/powerpc/include/asm/io.h:544:58: note: expanded from macro '__do_outsb'
   #define __do_outsb(p, b, n)     writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   In file included from fs/f2fs/super.c:12:
   In file included from include/linux/buffer_head.h:14:
   In file included from include/linux/pagemap.h:11:
   In file included from include/linux/highmem.h:10:
   In file included from include/linux/hardirq.h:10:
   In file included from arch/powerpc/include/asm/hardirq.h:6:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:199:1: note: expanded from here
   __do_outsw
   ^
   arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsw'
   #define __do_outsw(p, b, n)     writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   In file included from fs/f2fs/super.c:12:
   In file included from include/linux/buffer_head.h:14:
   In file included from include/linux/pagemap.h:11:
   In file included from include/linux/highmem.h:10:
   In file included from include/linux/hardirq.h:10:
   In file included from arch/powerpc/include/asm/hardirq.h:6:
   In file included from include/linux/irq.h:20:
   In file included from include/linux/io.h:13:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:201:1: note: expanded from here
   __do_outsl
   ^
   arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsl'
   #define __do_outsl(p, b, n)     writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   fs/f2fs/super.c:3419:12: warning: stack frame size of 2704 bytes in function 'f2fs_fill_super' [-Wframe-larger-than=]
   static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
              ^
>> fs/f2fs/super.c:3266:12: warning: stack frame size of 2192 bytes in function 'f2fs_scan_devices' [-Wframe-larger-than=]
   static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
              ^
   14 warnings generated.


vim +/f2fs_scan_devices +3266 fs/f2fs/super.c

26d815ad75156a Jaegeuk Kim   2015-04-20  3265  
3c62be17d4f562 Jaegeuk Kim   2016-10-06 @3266  static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3267  {
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3268  	struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi);
7bb3a371d19915 Masato Suzuki 2017-02-27  3269  	unsigned int max_devices = MAX_DEVICES;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3270  	int i;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3271  
7bb3a371d19915 Masato Suzuki 2017-02-27  3272  	/* Initialize single device information */
7bb3a371d19915 Masato Suzuki 2017-02-27  3273  	if (!RDEV(0).path[0]) {
7bb3a371d19915 Masato Suzuki 2017-02-27  3274  		if (!bdev_is_zoned(sbi->sb->s_bdev))
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3275  			return 0;
7bb3a371d19915 Masato Suzuki 2017-02-27  3276  		max_devices = 1;
7bb3a371d19915 Masato Suzuki 2017-02-27  3277  	}
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3278  
7bb3a371d19915 Masato Suzuki 2017-02-27  3279  	/*
7bb3a371d19915 Masato Suzuki 2017-02-27  3280  	 * Initialize multiple devices information, or single
7bb3a371d19915 Masato Suzuki 2017-02-27  3281  	 * zoned block device information.
7bb3a371d19915 Masato Suzuki 2017-02-27  3282  	 */
026f05079b00a5 Kees Cook     2018-06-12  3283  	sbi->devs = f2fs_kzalloc(sbi,
026f05079b00a5 Kees Cook     2018-06-12  3284  				 array_size(max_devices,
026f05079b00a5 Kees Cook     2018-06-12  3285  					    sizeof(struct f2fs_dev_info)),
026f05079b00a5 Kees Cook     2018-06-12  3286  				 GFP_KERNEL);
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3287  	if (!sbi->devs)
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3288  		return -ENOMEM;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3289  
7bb3a371d19915 Masato Suzuki 2017-02-27  3290  	for (i = 0; i < max_devices; i++) {
7bb3a371d19915 Masato Suzuki 2017-02-27  3291  
7bb3a371d19915 Masato Suzuki 2017-02-27  3292  		if (i > 0 && !RDEV(i).path[0])
7bb3a371d19915 Masato Suzuki 2017-02-27  3293  			break;
7bb3a371d19915 Masato Suzuki 2017-02-27  3294  
7bb3a371d19915 Masato Suzuki 2017-02-27  3295  		if (max_devices == 1) {
7bb3a371d19915 Masato Suzuki 2017-02-27  3296  			/* Single zoned block device mount */
7bb3a371d19915 Masato Suzuki 2017-02-27  3297  			FDEV(0).bdev =
7bb3a371d19915 Masato Suzuki 2017-02-27  3298  				blkdev_get_by_dev(sbi->sb->s_bdev->bd_dev,
7bb3a371d19915 Masato Suzuki 2017-02-27  3299  					sbi->sb->s_mode, sbi->sb->s_type);
7bb3a371d19915 Masato Suzuki 2017-02-27  3300  		} else {
7bb3a371d19915 Masato Suzuki 2017-02-27  3301  			/* Multi-device mount */
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3302  			memcpy(FDEV(i).path, RDEV(i).path, MAX_PATH_LEN);
7bb3a371d19915 Masato Suzuki 2017-02-27  3303  			FDEV(i).total_segments =
7bb3a371d19915 Masato Suzuki 2017-02-27  3304  				le32_to_cpu(RDEV(i).total_segments);
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3305  			if (i == 0) {
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3306  				FDEV(i).start_blk = 0;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3307  				FDEV(i).end_blk = FDEV(i).start_blk +
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3308  				    (FDEV(i).total_segments <<
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3309  				    sbi->log_blocks_per_seg) - 1 +
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3310  				    le32_to_cpu(raw_super->segment0_blkaddr);
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3311  			} else {
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3312  				FDEV(i).start_blk = FDEV(i - 1).end_blk + 1;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3313  				FDEV(i).end_blk = FDEV(i).start_blk +
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3314  					(FDEV(i).total_segments <<
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3315  					sbi->log_blocks_per_seg) - 1;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3316  			}
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3317  			FDEV(i).bdev = blkdev_get_by_path(FDEV(i).path,
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3318  					sbi->sb->s_mode, sbi->sb->s_type);
7bb3a371d19915 Masato Suzuki 2017-02-27  3319  		}
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3320  		if (IS_ERR(FDEV(i).bdev))
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3321  			return PTR_ERR(FDEV(i).bdev);
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3322  
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3323  		/* to release errored devices */
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3324  		sbi->s_ndevs = i + 1;
3c62be17d4f562 Jaegeuk Kim   2016-10-06  3325  

:::::: The code at line 3266 was first introduced by commit
:::::: 3c62be17d4f562f43fe1d03b48194399caa35aa5 f2fs: support multiple devices

:::::: TO: Jaegeuk Kim <jaegeuk@...nel.org>
:::::: CC: Jaegeuk Kim <jaegeuk@...nel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27208 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ