linux-kernel - [PATCH v2] fs/btrfs: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210417153616.25056-1-khaledromdhani216@gmail.com>
Date:   Sat, 17 Apr 2021 16:36:16 +0100
From:   Khaled ROMDHANI <khaledromdhani216@...il.com>
To:     clm@...com, josef@...icpanda.com, dsterba@...e.com
Cc:     Khaled ROMDHANI <khaledromdhani216@...il.com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: [PATCH v2] fs/btrfs: Fix uninitialized variable

As reported by the Coverity static analysis.
The variable zone is not initialized which
may causes a failed assertion.

Addresses-Coverity: ("Uninitialized variables")
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@...il.com>
---
v2: add a default case as proposed by David Sterba
---
 fs/btrfs/zoned.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index eeb3ebe11d7a..82527308d165 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -143,6 +143,9 @@ static inline u32 sb_zone_number(int shift, int mirror)
 	case 0: zone = 0; break;
 	case 1: zone = 1ULL << (BTRFS_SB_LOG_FIRST_SHIFT - shift); break;
 	case 2: zone = 1ULL << (BTRFS_SB_LOG_SECOND_SHIFT - shift); break;
+	default:
+		zone = 0;
+	break;
 	}
 
 	ASSERT(zone <= U32_MAX);
-- 
2.17.1