linux-kernel - Re: [PATCH] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210417172416.29509C433D3@smtp.codeaurora.org>
Date:   Sat, 17 Apr 2021 17:24:16 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Lee Gibson <leegib@...il.com>
Cc:     imitsyanko@...ntenna.com, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lee Gibson <leegib@...il.com>
Subject: Re: [PATCH] qtnfmac: Fix possible buffer overflow in
 qtnf_event_handle_external_auth

Lee Gibson <leegib@...il.com> wrote:

> Function qtnf_event_handle_external_auth calls memcpy without
> checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
> 
> Signed-off-by: Lee Gibson <leegib@...il.com>

Please use clamp_val() instead, that's preferred over min_t().

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210317121706.389058-1-leegib@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches