linux-kernel - Re: [PATCH] drm/msm: always parse interconnects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGv2701e+FMKX12+rHYwLpv06-kAo364Us7wEw6pAoC7Dg@mail.gmail.com>
Date:   Sat, 17 Apr 2021 10:52:49 -0700
From:   Rob Clark <robdclark@...il.com>
To:     Caleb Connolly <caleb@...nolly.tech>
Cc:     Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Kalyan Thota <kalyant@...eaurora.org>,
        ~postmarketos/upstreaming@...ts.sr.ht,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Rob Clark <robdclark@...omium.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm: always parse interconnects

On Sat, Apr 17, 2021 at 9:21 AM Caleb Connolly <caleb@...nolly.tech> wrote:
>
> The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
> platforms. As SDM845 now has interconnects hooked up we should always
> try and parse them.
>
> Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
> Signed-off-by: Caleb Connolly <caleb@...nolly.tech>

I believe this series in msm-next already solves this

https://patchwork.freedesktop.org/series/88644/

BR,
-R

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 85f2c3564c96..fb061e666faa 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -933,8 +933,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
>                 DPU_DEBUG("REG_DMA is not defined");
>         }
>
> -       if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
> -               dpu_kms_parse_data_bus_icc_path(dpu_kms);
> +       dpu_kms_parse_data_bus_icc_path(dpu_kms);
>
>         pm_runtime_get_sync(&dpu_kms->pdev->dev);
>
> --
> 2.30.2
>
>