linux-kernel - Re: [PATCH] media: atomisp: pci: remove unneeded variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210418150708.GA1402@agape.jhs>
Date:   Sun, 18 Apr 2021 17:07:09 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Saurav Girepunje <saurav.girepunje@...il.com>
Cc:     mchehab@...nel.org, sakari.ailus@...ux.intel.com,
        gregkh@...uxfoundation.org, saurav.girepunje@...gle.com,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, saurav.girepunje@...mail.com
Subject: Re: [PATCH] media: atomisp: pci: remove unneeded variable 'err'

On Sun, Apr 18, 2021 at 08:13:23PM +0530, Saurav Girepunje wrote:
> Fix the following coccicheck warning:
> 
> drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8:
> Unneeded variable: "err". Return "0" on line 44
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...gle.com>
> ---
>  drivers/staging/media/atomisp/pci/sh_css_mipi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index d5ae7f0b5864..708903a31b08 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -36,12 +36,11 @@ ref_count_mipi_allocation[N_CSI_PORTS]; /* Initialized in mipi_init */
>  int
>  ia_css_mipi_frame_specify(const unsigned int size_mem_words,
>  			  const bool contiguous) {
> -	int err = 0;
>  
>  	my_css.size_mem_words = size_mem_words;
>  	(void)contiguous;
>  
> -	return err;
> +	return 0;
>  }
>  
>  /*
> -- 
> 2.25.1
> 
> 

Hi Saurav,

this ia_css_mipi_frame_specify seems to be unused. On
header file, before the prototype it is said that it could
be removed only when all drivers moved to a new API.

Is that comment obsolete?

thank you,

fabio