linux-kernel - Re: [PATCH] ecryptfs: Fix typo in message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Apr 2021 12:38:19 -0500
From:   Tyler Hicks <code@...icks.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ecryptfs: Fix typo in message

On 2021-02-24 12:30:59, Sascha Hauer wrote:
> ecryptfs_decrypt_page() issues a warning "Error encrypting extent". This
> should be "Error decrypting extent" instead.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Thanks! This looks good. I'll add the following fixes line while
applying:

Fixes: 0216f7f79217 ("eCryptfs: replace encrypt, decrypt, and inode size write")

Tyler

> ---
>  fs/ecryptfs/crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
> index a48116aae02c..0fed4ff02f69 100644
> --- a/fs/ecryptfs/crypto.c
> +++ b/fs/ecryptfs/crypto.c
> @@ -535,7 +535,7 @@ int ecryptfs_decrypt_page(struct page *page)
>  		rc = crypt_extent(crypt_stat, page, page,
>  				  extent_offset, DECRYPT);
>  		if (rc) {
> -			printk(KERN_ERR "%s: Error encrypting extent; "
> +			printk(KERN_ERR "%s: Error decrypting extent; "
>  			       "rc = [%d]\n", __func__, rc);
>  			goto out;
>  		}
> -- 
> 2.29.2
>