linux-kernel - Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3163466.7bx4QQXRp1@pc-42>
Date:   Mon, 19 Apr 2021 17:55:34 +0200
From:   Jérôme Pouiller <jerome.pouiller@...abs.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Ashish Kalra <eashishkalra@...il.com>
Subject: Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning

On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote:
> 
> Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
> Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
> Should it be static?" is brought to notice for this file.  static keyword
> should be added to prevent this warning. let's add it to make it cleaner and
> silence the Sparse warning.

Hi Ashish,

Thank you for your contribution.

It seems that this issue is already fixed by commit ce59858bbc10 "staging:
wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
in master in version 5.8). Can you check you are working on the last tree?


-- 
Jérôme Pouiller