linux-kernel - Re: [PATCH][next] bcache: Set error return err to -ENOMEM on allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85f515b5-05a0-5844-bed7-0287f845f491@suse.de>
Date:   Tue, 20 Apr 2021 00:04:10 +0800
From:   Coly Li <colyli@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-bcache@...r.kernel.org, Jianpeng Ma <jianpeng.ma@...el.com>,
        Jens Axboe <axboe@...nel.dk>,
        Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: [PATCH][next] bcache: Set error return err to -ENOMEM on
 allocation failure

On 4/19/21 8:56 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently when ns fails to be allocated the error return path returns
> an uninitialized return code in variable 'err'. Fix this by setting
> err to -ENOMEM.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/md/bcache/nvm-pages.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/md/bcache/nvm-pages.c b/drivers/md/bcache/nvm-pages.c
> index 08cd45e90481..2e124d546099 100644
> --- a/drivers/md/bcache/nvm-pages.c
> +++ b/drivers/md/bcache/nvm-pages.c
> @@ -584,6 +584,7 @@ struct bch_nvm_namespace *bch_register_namespace(const char *dev_path)
>  		return ERR_PTR(PTR_ERR(bdev));
>  	}
>  
> +	err = -ENOMEM;
>  	ns = kzalloc(sizeof(struct bch_nvm_namespace), GFP_KERNEL);
>  	if (!ns)
>  		goto bdput;
> 

Copied, added into my queue for rc1.

Thanks.

Coly Li