linux-kernel - RE: [PATCH 1/1 v9] use crc32 instead of md5 for hibernation e820 integrity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB08921161444D6D2683660853BF499@MW2PR2101MB0892.namprd21.prod.outlook.com>
Date:   Mon, 19 Apr 2021 23:33:20 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Chris von Recklinghausen <crecklin@...hat.com>,
        "ebiggers@...nel.org" <ebiggers@...nel.org>,
        "ardb@...nel.org" <ardb@...nel.org>,
        "simo@...hat.com" <simo@...hat.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1 v9] use crc32 instead of md5 for hibernation e820
 integrity check

> From: Chris von Recklinghausen <crecklin@...hat.com>
> Sent: Friday, April 16, 2021 6:17 AM
>  ...
> Hibernation fails on a system in fips mode because md5 is used for the e820
> integrity check and is not available. Use crc32 instead.
> 
> The check is intended to detect whether the E820 memory map provided
> by the firmware after cold boot unexpectedly differs from the one that
> was in use when the hibernation image was created. In this case, the
> hibernation image cannot be restored, as it may cover memory regions
> that are no longer available to the OS.
> 
> A non-cryptographic checksum such as CRC-32 is sufficient to detect such
> inadvertent deviations.
> 
> Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory
> map
>        by md5 digest")
> 
> Signed-off-by: Chris von Recklinghausen <crecklin@...hat.com>
> ---

Tested-by: Dexuan Cui <decui@...rosoft.com>
Reviewed-by: Dexuan Cui <decui@...rosoft.com>

Thanks Chris and all for the patch!