linux-kernel - Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210419072229.GA4869@dell>
Date:   Mon, 19 Apr 2021 08:22:29 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     ChiYuan Huang <u0084500@...il.com>
Cc:     lgirdwood@...il.com, Mark Brown <broonie@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        jingoohan1@...il.com, b.zolnierkie@...sung.com,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>,
        ChiYuan Huang <cy_huang@...htek.com>
Subject: Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831

On Mon, 19 Apr 2021, ChiYuan Huang wrote:

> Hi, Linux mfd reviewers:
>    It's been three weeks not to get any response from you.
> Is there something wrong about this mfd patch?
> If yes, please feel free to let me know.

Couple of things:

First, if you think a patch had fallen through the gaps, which does
happen sometimes, it is generally considered acceptable to submit a
[RESEND] ~2 weeks after the initial submission.  FYI: This was such a
patch.  It was not on, or had fallen off of my radar for some reason.

Secondly, we are really late in the release cycle.  -rc8 has just been
released.  Quite a few maintainers slow down at ~-rc6.  Particularly
for new drivers.

No need to resubmit this driver this time.  It is now on my to-review
list and I will tend to it shortly.

Thanks for your patience.

> cy_huang <u0084500@...il.com> 於 2021年3月28日 週日 下午11:24寫道：
> >
> > From: ChiYuan Huang <cy_huang@...htek.com>
> >
> > This adds support Richtek RT4831 core. It includes four channel WLED driver
> > and Display Bias Voltage outputs.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> > ---
> > The RT4831 regulator patches are already on main stream, and can be referred to
> > 9351ab8b0cb6 regulator: rt4831: Adds support for Richtek RT4831 DSV regulator
> > 934b05e81862 regulator: rt4831: Adds DT binding document for Richtek RT4831 DSV regulator
> >
> > since v6
> > - Respin the date from 2020 to 2021.
> > - Rmove the shutdown routine.
> > - Change the macro OF_MFD_CELL to MFD_CELL_OF.
> >
> >
> > since v5
> > - Rename file name from rt4831-core.c to rt4831.c
> > - Change RICHTEK_VID to RICHTEK_VENDOR_ID.
> > - Change gpio_desc nameing from 'enable' to 'enable_gpio' in probe.
> > - Change variable 'val' to the meaningful name 'chip_id'.
> > - Refine the error log when vendor id is not matched.
> > - Remove of_match_ptr.
> >
> > since v2
> > - Refine Kconfig descriptions.
> > - Add copyright.
> > - Refine error logs in probe.
> > - Refine comment lines in remove and shutdown.
> > ---
> >  drivers/mfd/Kconfig  |  10 +++++
> >  drivers/mfd/Makefile |   1 +
> >  drivers/mfd/rt4831.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 126 insertions(+)
> >  create mode 100644 drivers/mfd/rt4831.c

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog