linux-kernel - Re: drivers/net/ethernet/mediatek/mtk_ppe_offload.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210419080610.GA24040@salvia>
Date:   Mon, 19 Apr 2021 10:06:10 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     Felix Fietkau <nbd@....name>,
        "David S. Miller" <davem@...emloft.net>,
        Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: drivers/net/ethernet/mediatek/mtk_ppe_offload.c - suspicious
 code?

On Sun, Apr 18, 2021 at 09:02:12PM -0400, Valdis Klētnieks wrote:
> While doing some code auditing for -Woverride_init, I spotted some questionable code
> 
> commit 502e84e2382d92654a2ecbc52cdbdb5a11cdcec7
> Author: Felix Fietkau <nbd@....name>
> Date:   Wed Mar 24 02:30:54 2021 +0100
> 
>     net: ethernet: mtk_eth_soc: add flow offloading support
> 
> In drivers/net/ethernet/mediatek/mtk_ppe_offload.c:
> 
> +static const struct rhashtable_params mtk_flow_ht_params = {
> +       .head_offset = offsetof(struct mtk_flow_entry, node),
> +       .head_offset = offsetof(struct mtk_flow_entry, cookie),
> +       .key_len = sizeof(unsigned long),
> +       .automatic_shrinking = true,
> +};
> 
> What's intended for head_offset here?

It's a bug, there's a fix here:

https://www.spinics.net/lists/netdev/msg736368.html