linux-kernel - RE: [PATCH 3/7] mfd: da9052: Simplify getting of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PR3PR10MB414231DE2AC6E7B8326D0CE380499@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 19 Apr 2021 11:00:04 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        Lee Jones <lee.jones@...aro.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Tony Lindgren <tony@...mide.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>
Subject: RE: [PATCH 3/7] mfd: da9052: Simplify getting of_device_id match data

On 19 April 2021 09:17, Krzysztof Kozlowski wrote:

> Use of_device_get_match_data() to make the code slightly smaller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---

Acked-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>

>  drivers/mfd/da9052-i2c.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 47556d2d9abe..5d8ce8dca3fc 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -154,13 +154,8 @@ static int da9052_i2c_probe(struct i2c_client *client,
>  		return ret;
> 
>  #ifdef CONFIG_OF
> -	if (!id) {
> -		struct device_node *np = client->dev.of_node;
> -		const struct of_device_id *deviceid;
> -
> -		deviceid = of_match_node(dialog_dt_ids, np);
> -		id = deviceid->data;
> -	}
> +	if (!id)
> +		id = of_device_get_match_data(&client->dev);
>  #endif
> 
>  	if (!id) {
> --
> 2.25.1