linux-kernel - RE: [PATCH v2 1/2] mmc: block: Issue flush only if allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR04MB657548286A24A6B033694691FC499@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Mon, 19 Apr 2021 12:48:52 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     linux-mmc <linux-mmc@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Brendan Peter <bpeter@...x.com>
Subject: RE: [PATCH v2 1/2] mmc: block: Issue flush only if allowed

> 
> On Sun, 18 Apr 2021 at 08:00, Avri Altman <avri.altman@....com> wrote:
> >
> > The cache may be flushed to the nonvolatile storage by writing to
> > FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode,
> the
> > cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a
> > FLUSH_CACHE op-code.  Either way, verify that The cache function is
> > turned ON before doing so.
> 
> Avri, thanks for your patch. Overall this looks good to me.
> 
> However things are becoming more and more messy in these layers of the
> mmc core. In particular, I would like us to take advantage of the
> bus_ops callbacks, when eMMC and/or SD specific features need
> different implementations.
> 
> I have posted a patch [1], that moves the eMMC cache flushing into a
> bus_ops callback. Would you mind rebasing this series on top of that?
Sure.

Thanks,
Avri

> 
> Kind regards
> Uffe
> 
> [1]
> https://patchwork.kernel.org/project/linux-
> mmc/patch/20210419122943.68234-1-ulf.hansson@...aro.org/