[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210419132159.4450-1-tomas.melin@vaisala.com>
Date: Mon, 19 Apr 2021 16:21:57 +0300
From: Tomas Melin <tomas.melin@...sala.com>
To: jic23@...nel.org, devicetree@...r.kernel.org
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v3 0/2] iio: accel: sca3300: Accelerometer support and binding docs
Patch series adds driver and dt-bindings for Murata SCA3300 accelerometer.
Device is a 3-axis Accelerometer with digital SPI interface.
Patches are tested and based on linux-next.
Changes V3:
Addressed comments from Jonathan Cameron and Andy Shevchenko
- Grouped include statements
- Revised SCA* define naming and grouped statements
- Changed to GENMASK() for masks
- Indentation fix for ACCEL_CHANNEL define
- Remove field declarations using default values
- Change to if(ret) style for checking return values
- Add defined mask value SCA3300_MASK_STATUS for return status
- Remove redundant type casts
- Clarify comment wording
- Refactor to remove variable idx and redundant else branches
- Unify sleep in device init, separate sleeps not needed since operation mode change dropped
- Drop redundant memory allocation error message in probe
- dev.parent is set by iio core, removed from driver probe
- Drop of_match_ptr()
Changes V2:
Addressed comments from Jonathan Cameron
- Add manufacturer name to dt-binding file
- Update spdx license statement for dt-bindings
- Remove murata,opmode devicetree property in favor of driver scale + frequency properties
- Add copyright year for driver
- Remove X_READ and X_WRITE defines
- Add _available sysfs attributes
- Fix errors in documentation formatting
- Use ARRAY_SIZE where applicable
- Use get/put_unaligned_be16() helpers where applicable
- Factor out error handling to separate function
- Return only negative values from transfer function
- Fix INFO_SCALE to return multiplier instead of inverted value
- Change INFO_SCALE values to be actual scale instead of mode value
- Do not provide INFO_PROCESSED values for user space
- Add error message for failed data read in irq handler
- Move trigger handler timestamping as part of pushing data to buffers
- Document startup sequence, providing reference to data sheet section
- Convert iio_triggered_buffer_setup to devm_iio_triggered_buffer_setup,
making remove() obsolete
Tomas Melin (2):
dt-bindings: iio: accel: Add SCA3300 documentation
iio: accel: Add driver for Murata SCA3300 accelerometer
Documentation/devicetree/bindings/iio/accel/murata,sca3300.yaml | 44 ++++++++++++++++++
drivers/iio/accel/Kconfig | 13 ++++++
drivers/iio/accel/Makefile | 1 +
drivers/iio/accel/sca3300.c | 462 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 520 insertions(+)
Powered by blists - more mailing lists