linux-kernel - Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Apr 2021 17:16:52 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Joe Perches <joe@...ches.com>,
        Sebastian Fricke <sebastian.fricke@...teo.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

On Sun, Apr 18, 2021 at 11:22 AM Joe Perches <joe@...ches.com> wrote:
>
> On Sun, 2021-04-18 at 09:11 +0000, Sebastian Fricke wrote:
> > Hey Joe,
>
> Hi Sebastian.
>
> > On 18.04.2021 00:09, Joe Perches wrote:
> > > On Sun, 2021-04-18 at 06:08 +0000, Sebastian Fricke wrote:
> > > > Remove a redundant space to improve the quality of the comment.
> > > I think this patch is not useful.
> > > It's not redundant.
> >
> > Thank you, I actually found this pattern a few more times but I wanted
> > to check first if this is a mistake or chosen consciously.

I write a double space after a period ending a sentence as a rule and
it is not a mistake.

> []
> > > For drivers/base/power/runtime.c, that 2 space after period style is used
> > > dozens of times and changing a single instance of it isn't very useful.
>
> Even in that single file it's not consistent.
> It's something like 3:1 for 2 spaces over 1 space after period.
>
> I believe it's done more by habit and author age than anything.
> If you learned to type using a typewriter and not a keyboard, then
> you likely still use 2 spaces after a period.

By habit and because I prefer it this way (I find it somewhat easier
to separate sentences from one another this way).

> > True and if I understand you correctly you would rather keep it as is
> > right?
>
> Yes.  IMO: Whitespace in comments like this should not be changed
> unless there's some other significant benefit like better alignment.

Agreed.