linux-kernel - [PATCH][next] selftests: add missing void in MREMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210420220626.391888-1-colin.king@canonical.com>
Date:   Tue, 20 Apr 2021 23:06:26 +0100
From:   Colin King <colin.king@...onical.com>
To:     Shuah Khan <shuah@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kselftest@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] selftests: add missing void in MREMAP_DONTUNMAP selftest function prototypes

From: Colin Ian King <colin.king@...onical.com>

There are a few function prototypes that are missing a void parameter,
fix this by adding it in.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 tools/testing/selftests/vm/mremap_dontunmap.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/vm/mremap_dontunmap.c b/tools/testing/selftests/vm/mremap_dontunmap.c
index f01dc4a85b0b..78baaf0e85d9 100644
--- a/tools/testing/selftests/vm/mremap_dontunmap.c
+++ b/tools/testing/selftests/vm/mremap_dontunmap.c
@@ -42,7 +42,7 @@ static void dump_maps(void)
 
 // Try a simple operation for to "test" for kernel support this prevents
 // reporting tests as failed when it's run on an older kernel.
-static int kernel_support_for_mremap_dontunmap()
+static int kernel_support_for_mremap_dontunmap(void)
 {
 	int ret = 0;
 	unsigned long num_pages = 1;
@@ -95,7 +95,7 @@ static int check_region_contains_byte(void *addr, unsigned long size, char byte)
 
 // this test validates that MREMAP_DONTUNMAP moves the pagetables while leaving
 // the source mapping mapped.
-static void mremap_dontunmap_simple()
+static void mremap_dontunmap_simple(void)
 {
 	unsigned long num_pages = 5;
 
@@ -128,7 +128,7 @@ static void mremap_dontunmap_simple()
 }
 
 // This test validates that MREMAP_DONTUNMAP on a shared mapping works as expected.
-static void mremap_dontunmap_simple_shmem()
+static void mremap_dontunmap_simple_shmem(void)
 {
 	unsigned long num_pages = 5;
 
@@ -181,7 +181,7 @@ static void mremap_dontunmap_simple_shmem()
 // This test validates MREMAP_DONTUNMAP will move page tables to a specific
 // destination using MREMAP_FIXED, also while validating that the source
 // remains intact.
-static void mremap_dontunmap_simple_fixed()
+static void mremap_dontunmap_simple_fixed(void)
 {
 	unsigned long num_pages = 5;
 
@@ -226,7 +226,7 @@ static void mremap_dontunmap_simple_fixed()
 
 // This test validates that we can MREMAP_DONTUNMAP for a portion of an
 // existing mapping.
-static void mremap_dontunmap_partial_mapping()
+static void mremap_dontunmap_partial_mapping(void)
 {
 	/*
 	 *  source mapping:
-- 
2.30.2