linux-kernel - Re: [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4hV1HhFRw42s=tc_8dLeY4+avB_2jauSxVzUBzKsEr8ew@mail.gmail.com>
Date:   Tue, 20 Apr 2021 16:58:06 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Vishal L Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Santosh Sivaraj <santosh@...six.org>,
        "Weiny, Ira" <ira.weiny@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v2] tools/testing/nvdimm: Make symbol
 '__nfit_test_ioremap' static

On Tue, Apr 20, 2021 at 12:31 AM Zou Wei <zou_wei@...wei.com> wrote:
>
> The sparse tool complains as follows:
>
> tools/testing/nvdimm/test/iomap.c:65:14: warning:
>  symbol '__nfit_test_ioremap' was not declared. Should it be static?
>
> This symbol is not used outside of iomap.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Looks good to me, thanks.