linux-kernel - Re: [PATCH AUTOSEL 5.4 13/14] gcov: clang: fix clang-11+ build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74494183e65ef549fc5596f314db43a8e792d2ff.camel@sipsolutions.net>
Date:   Tue, 20 Apr 2021 09:01:19 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH AUTOSEL 5.4 13/14] gcov: clang: fix clang-11+ build

On Mon, 2021-04-19 at 20:44 +0000, Sasha Levin wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> [ Upstream commit 04c53de57cb6435738961dace8b1b71d3ecd3c39 ]
> 
> With clang-11+, the code is broken due to my kvmalloc() conversion
> (which predated the clang-11 support code) leaving one vmalloc() in
> place.  Fix that.

This patch might *apply* on 5.4 (and the other kernels you selected it
for), but then I'm pretty sure it'll be broken, unless you also applied
the various patches this was actually fixing (my kvmalloc conversion,
and the clang-11 support).

Also, Linus has (correctly) reverted this patch from mainline, it
shouldn't have gone there in the first place, probably really should be
squashed into my kvmalloc conversion patch that's in -mm now.

Sorry if I didn't make that clear enough at the time.

In any case, please drop this patch from all stable trees.

johannes