linux-kernel - Re: [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <066633f6-e624-54ef-0de0-5589305fdbe3@huawei.com>
Date:   Tue, 20 Apr 2021 15:19:15 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     Santosh Sivaraj <santosh@...six.org>, <dan.j.williams@...el.com>,
        <vishal.l.verma@...el.com>, <dave.jiang@...el.com>,
        <ira.weiny@...el.com>
CC:     <linux-nvdimm@...ts.01.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] tools/testing/nvdimm: Make symbol
 '__nfit_test_ioremap' static

Hi Santosh,

Thanks for your review, and sorry for my mistake. I will send the v2 soon.

On 2021/4/20 14:35, Santosh Sivaraj wrote:
> 
> Hi Zou,
> 
> Zou Wei <zou_wei@...wei.com> writes:
> 
>> The sparse tool complains as follows:
>>
>> tools/testing/nvdimm/test/iomap.c:65:14: warning:
>>   symbol '__nfit_test_ioremap' was not declared. Should it be static?
>>
>> This symbol is not used outside of security.c, so this
> 
> s/security.c/iomap.c/
> 
> Thanks,
> Santosh
> 
>> commit marks it static.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zou Wei <zou_wei@...wei.com>
>> ---
>>   tools/testing/nvdimm/test/iomap.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
>> index c62d372..ed563bd 100644
>> --- a/tools/testing/nvdimm/test/iomap.c
>> +++ b/tools/testing/nvdimm/test/iomap.c
>> @@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource)
>>   }
>>   EXPORT_SYMBOL(get_nfit_res);
>>   
>> -void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
>> +static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
>>   		void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
>>   {
>>   	struct nfit_test_resource *nfit_res = get_nfit_res(offset);
>> -- 
>> 2.6.2
>> _______________________________________________
>> Linux-nvdimm mailing list -- linux-nvdimm@...ts.01.org
>> To unsubscribe send an email to linux-nvdimm-leave@...ts.01.org
> .
>