linux-kernel - [PATCH] x86, sched: Fix the AMD CPPC maximum perf on some specific generations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210420080943.1045886-1-ray.huang@amd.com>
Date:   Tue, 20 Apr 2021 16:09:43 +0800
From:   Huang Rui <ray.huang@....com>
To:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Alex Deucher <alexander.deucher@....com>,
        Jason Bagavatsingham <jason.bagavatsingham@...il.com>,
        "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
        Huang Rui <ray.huang@....com>,
        Nathan Fontenot <nathan.fontenot@....com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Borislav Petkov <bp@...e.de>, x86@...nel.org
Subject: [PATCH] x86, sched: Fix the AMD CPPC maximum perf on some specific generations

Some AMD Ryzen generations has different calculation method on maximum
perf. 255 is not for all asics, some specific generations used 166 as
the maximum perf. This patch is to fix the different maximum perf value
of AMD CPPC.

Fixes: 41ea667227ba ("x86, sched: Calculate frequency invariance for AMD systems")
Fixes: 3c55e94c0ade ("cpufreq: ACPI: Extend frequency tables to cover boost frequencies")

Reported-by: Jason Bagavatsingham <jason.bagavatsingham@...il.com>
Tested-by: Jason Bagavatsingham <jason.bagavatsingham@...il.com>
Signed-off-by: Huang Rui <ray.huang@....com>
Cc: Alex Deucher <alexander.deucher@....com>
Cc: Nathan Fontenot <nathan.fontenot@....com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Cc: Borislav Petkov <bp@...e.de>
Cc: x86@...nel.org
---
 arch/x86/kernel/smpboot.c      | 33 ++++++++++++++++++++++++++-
 drivers/cpufreq/acpi-cpufreq.c | 41 ++++++++++++++++++++++++++++++++++
 2 files changed, 73 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 02813a7f3a7c..705bc5ceb1ea 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -2033,6 +2033,37 @@ static bool intel_set_max_freq_ratio(void)
 }
 
 #ifdef CONFIG_ACPI_CPPC_LIB
+static u64 amd_get_highest_perf(void)
+{
+	u64 cppc_max_perf;
+
+	switch (boot_cpu_data.x86) {
+	case 0x17:
+		if ((boot_cpu_data.x86_model >= 0x30 &&
+		     boot_cpu_data.x86_model < 0x40) ||
+		    (boot_cpu_data.x86_model >= 0x70 &&
+		     boot_cpu_data.x86_model < 0x80))
+			cppc_max_perf = 166;
+		else
+			cppc_max_perf = 255;
+		break;
+	case 0x19:
+		if ((boot_cpu_data.x86_model >= 0x20 &&
+		     boot_cpu_data.x86_model < 0x30) ||
+		    (boot_cpu_data.x86_model >= 0x40 &&
+		     boot_cpu_data.x86_model < 0x70))
+			cppc_max_perf = 166;
+		else
+			cppc_max_perf = 255;
+		break;
+	default:
+		cppc_max_perf = 255;
+		break;
+	}
+
+	return cppc_max_perf;
+}
+
 static bool amd_set_max_freq_ratio(void)
 {
 	struct cppc_perf_caps perf_caps;
@@ -2046,8 +2077,8 @@ static bool amd_set_max_freq_ratio(void)
 		return false;
 	}
 
-	highest_perf = perf_caps.highest_perf;
 	nominal_perf = perf_caps.nominal_perf;
+	highest_perf = amd_get_highest_perf();
 
 	if (!highest_perf || !nominal_perf) {
 		pr_debug("Could not retrieve highest or nominal performance\n");
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index d1bbc16fba4b..e5c03360db20 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -630,6 +630,44 @@ static int acpi_cpufreq_blacklist(struct cpuinfo_x86 *c)
 #endif
 
 #ifdef CONFIG_ACPI_CPPC_LIB
+
+static u64 get_amd_max_boost_ratio(unsigned int cpu, u64 nominal_perf)
+{
+	u64 boost_ratio, cppc_max_perf;
+
+	if (!nominal_perf)
+		return 0;
+
+	switch (boot_cpu_data.x86) {
+	case 0x17:
+		if ((boot_cpu_data.x86_model >= 0x30 &&
+		     boot_cpu_data.x86_model < 0x40) ||
+		    (boot_cpu_data.x86_model >= 0x70 &&
+		     boot_cpu_data.x86_model < 0x80))
+			cppc_max_perf = 166;
+		else
+			cppc_max_perf = 255;
+		break;
+	case 0x19:
+		if ((boot_cpu_data.x86_model >= 0x20 &&
+		     boot_cpu_data.x86_model < 0x30) ||
+		    (boot_cpu_data.x86_model >= 0x40 &&
+		     boot_cpu_data.x86_model < 0x70))
+			cppc_max_perf = 166;
+		else
+			cppc_max_perf = 255;
+		break;
+	default:
+		cppc_max_perf = 255;
+		break;
+	}
+
+	boost_ratio = div_u64(cppc_max_perf << SCHED_CAPACITY_SHIFT,
+			      nominal_perf);
+
+	return boost_ratio;
+}
+
 static u64 get_max_boost_ratio(unsigned int cpu)
 {
 	struct cppc_perf_caps perf_caps;
@@ -646,6 +684,9 @@ static u64 get_max_boost_ratio(unsigned int cpu)
 		return 0;
 	}
 
+	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
+		return get_amd_max_boost_ratio(cpu, perf_caps.nominal_perf);
+
 	highest_perf = perf_caps.highest_perf;
 	nominal_perf = perf_caps.nominal_perf;
 
-- 
2.25.1