linux-kernel - Re: [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h7k1qs8u.wl-maz@kernel.org>
Date:   Tue, 20 Apr 2021 09:23:29 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     tglx@...utronix.de, michal.simek@...inx.com,
        linux-kernel@...r.kernel.org, anirudh@...inx.com
Subject: Re: [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP

On Mon, 19 Apr 2021 20:42:45 +0100,
Robert Hancock <robert.hancock@...ian.com> wrote:
> 
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on the Zynq and ZynqMP platforms as a secondary cascaded
> controller. Allow this option to be user-enabled on those platforms.
> 
> Signed-off-by: Robert Hancock <robert.hancock@...ian.com>
> ---
>  drivers/irqchip/Kconfig | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 15536e321df5..1020cc5a7800 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -279,8 +279,13 @@ config XTENSA_MX
>  	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
>  
>  config XILINX_INTC
> -	bool
> +	bool "Xilinx Interrupt Controller IP"
> +	depends on MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST

Please drop COMPILE_TEST. As reported by the kernel test bot, there
are architectures it can't be compiled on.

	M.

-- 
Without deviation from the norm, progress is not possible.