linux-kernel - Re: [PATCH v13 05/12] KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f713a9ff-925c-0eaf-c9d3-297efece6d26@redhat.com>
Date:   Tue, 20 Apr 2021 10:43:04 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Ashish Kalra <Ashish.Kalra@....com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        joro@...tes.org, bp@...e.de, thomas.lendacky@....com,
        x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        srutherford@...gle.com, seanjc@...gle.com,
        venu.busireddy@...cle.com, brijesh.singh@....com
Subject: Re: [PATCH v13 05/12] KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA
 command

On 20/04/21 10:40, Paolo Bonzini wrote:
> On 15/04/21 17:55, Ashish Kalra wrote:
>> +    if (!guest_page)
>> +        goto e_free;
>> +
> 
> Missing unpin on error (but it won't be needed with Sean's patches that 
> move the data block to the stack, so I can fix this too).

No, sorry---the initialization order is different between 
send_update_data and receive_update_data, so it's okay.

Paolo