linux-kernel - Re: [RESEND v2] iommu/vt-d: Use passthrough mode for the Intel IPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210420105640.GI3@paasikivi.fi.intel.com>
Date:   Tue, 20 Apr 2021 13:56:40 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Bingbu Cao <bingbu.cao@...ux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        iommu@...ts.linux-foundation.org, dwmw2@...radead.org,
        baolu.lu@...ux.intel.com, joro@...tes.org, will@...nel.org,
        bhelgaas@...gle.com, rajatja@...gle.com, grundler@...omium.org,
        tfiga@...omium.org, senozhatsky@...omium.org
Subject: Re: [RESEND v2] iommu/vt-d: Use passthrough mode for the Intel IPUs

Hi Bingbu,

On Tue, Apr 20, 2021 at 06:34:26PM +0800, Bingbu Cao wrote:
> Andy,
> 
> On 4/20/21 6:20 PM, Andy Shevchenko wrote:
> > On Tue, Apr 20, 2021 at 10:48:33AM +0800, Bingbu Cao wrote:
> >> Intel IPU(Image Processing Unit) has its own (IO)MMU hardware,
> >> The IPU driver allocates its own page table that is not mapped
> >> via the DMA, and thus the Intel IOMMU driver blocks access giving
> >> this error:
> >>
> >> DMAR: DRHD: handling fault status reg 3
> >> DMAR: [DMA Read] Request device [00:05.0] PASID ffffffff
> >>       fault addr 76406000 [fault reason 06] PTE Read access is not set
> >>
> >> As IPU is not an external facing device which is not risky, so use
> >> IOMMU passthrough mode for Intel IPUs.
> >>
> >> Fixes: 26f5689592e2 ("media: staging/intel-ipu3: mmu: Implement driver")
> >> Signed-off-by: Bingbu Cao <bingbu.cao@...el.com>
> >> ---
> >>  drivers/iommu/intel/iommu.c | 29 +++++++++++++++++++++++++++++
> > 
> > This misses the changelog from v1 followed by the explanation why resent.
> > 
> I noticed there was a typo in the recipient list:
> stable.vger.kernel.org -> stable@...r.kernel.org
> 
> no code change for resent.

When you're submitting a patch and want it reach the stable kernels, you'll
need to add a Cc tag:

	Cc: stable@...r.kernel.org

But not actually add the address to cc. I dropped stable@...r address from
distribution.

Please change this for v3.

-- 
Kind regards,

Sakari Ailus