linux-kernel - Re: [PATCH] tty: synclink_gt: remove redundant initialization of variable count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de4f4627-a3e4-aa85-c10d-99677c6fcb57@kernel.org>
Date:   Tue, 20 Apr 2021 13:02:58 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: synclink_gt: remove redundant initialization of
 variable count

On 20. 04. 21, 12:57, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable count is being initialized with a value that is
> never read and it is being updated later with a new value.  The
> initialization is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/synclink_gt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
> index 994618618466..5523cf7bd1c2 100644
> --- a/drivers/tty/synclink_gt.c
> +++ b/drivers/tty/synclink_gt.c
> @@ -4958,7 +4958,7 @@ static int loopback_test(struct slgt_info *info)
>   #define TESTFRAMESIZE 20
>   
>   	unsigned long timeout;
> -	u16 count = TESTFRAMESIZE;
> +	u16 count;
>   	unsigned char buf[TESTFRAMESIZE];
>   	int rc = -ENODEV;
>   	unsigned long flags;
> 


-- 
js