linux-kernel - Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2104211810200.44318@angie.orcam.me.uk>
Date:   Wed, 21 Apr 2021 18:16:18 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     "H. Nikolaus Schaller" <hns@...delico.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
cc:     Arnd Bergmann <arnd@...db.de>, Huacai Chen <chenhuacai@...nel.org>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-arch@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be
 zero

On Wed, 21 Apr 2021, H. Nikolaus Schaller wrote:

> > We already check the high part of the divident against zero to avoid the 
> 
> nit-picking: s/divident/dividend/

 Umm, I find this embarassing (and I hesitated reaching for a dictionary 
to double-check the spelling!).  Indeed why would this be different from 
subtrahend or minuend?

 Thomas, as this mistake has spread across three out of these patches,
both in change descriptions and actual code, would you mind dropping the 
series from mips-next altogether and I'll respin the series with all 
these issues corrected?

  Maciej