linux-kernel - Re: [PATCH 085/190] Revert "audit: fix a memory leak bug"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 18:26:47 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Paul Moore <paul@...l-moore.com>
Cc:     linux-kernel@...r.kernel.org, Wenwen Wang <wang6495@....edu>,
        Richard Guy Briggs <rgb@...hat.com>
Subject: Re: [PATCH 085/190] Revert "audit: fix a memory leak bug"

On Wed, Apr 21, 2021 at 12:18:44PM -0400, Paul Moore wrote:
> On Wed, Apr 21, 2021 at 9:04 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > This reverts commit 70c4cf17e445264453bc5323db3e50aa0ac9e81f.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Wenwen Wang <wang6495@....edu>
> > Cc: Richard Guy Briggs <rgb@...hat.com>
> > Cc: Paul Moore <paul@...l-moore.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  kernel/auditfilter.c | 12 +++++-------
> >  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> NACK on this revert.  I've looked at the original patch again this
> morning, and the original patch still looks correct and doesn't appear
> to introduce any new faults to the best of my understanding.
> 

Thanks for the review, much appreciate it, I'll drop it.

greg k-h