linux-kernel - Re: [PATCH] PCI/VPD: fix unused pci_vpd_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIBYvJV0Hr7pt/T1@client-192-168-1-100.lan>
Date:   Wed, 21 Apr 2021 18:54:20 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/VPD: fix unused pci_vpd_set_size function warning

Hi Arnd,

> The only user of this function is now in an #ifdef, causing
> a warning when that symbol is not defined:
> 
> drivers/pci/vpd.c:289:13: error: 'pci_vpd_set_size' defined but not used [-Werror=unused-function]
>   289 | static void pci_vpd_set_size(struct pci_dev *dev, size_t len)
> 
> Move the function into that #ifdef block.
[...]

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Krzysztof