linux-kernel - Re: [PATCH 2/2] ACPI: irq: Prevent unregistering of GIC SGIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 18:15:16 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Hanjun Guo <guohanjun@...wei.com>,
        dann frazier <dann.frazier@...onical.com>,
        Fu Wei <wefu@...hat.com>, Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH 2/2] ACPI: irq: Prevent unregistering of GIC SGIs

On Wed, Apr 21, 2021 at 05:43:17PM +0100, Marc Zyngier wrote:
> When using ACPI on arm64, which implies the GIC IRQ model, no
> table should ever provide a GSI number in the range [0:15],
> as these are reserved for IPIs.
>
> However, drivers tend to call acpi_unregister_gsi() with any
> random GSI number provided by half baked tables, which results
> in an exploding kernel when its IPIs have been unconfigured.
>
> In order to catch this, check for the silly case early, warn
> that something is going wrong and avoid the above disaster.
>

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

Just curious if this is just precaution or do we have a platform doing
something stupid like this ?

--
Regards,
Sudeep