linux-kernel - Re: [PATCH 000/190] Revertion of all of the umn.edu commits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIBlggJ2hZ3TYszc@zeniv-ca.linux.org.uk>
Date:   Wed, 21 Apr 2021 17:48:50 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Kangjie Lu <kjlu@....edu>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jiri Kosina <jikos@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Aditya Pakki <pakki001@....edu>, Qiushi Wu <wu000273@....edu>,
        x86@...nel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>,
        Michael Turquette <mturquette@...libre.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Jean Delvare <jdelvare@...e.com>,
        Will Deacon <will@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Johan Hovold <johan@...nel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Johannes Berg <johannes@...solutions.net>,
        Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 000/190] Revertion of all of the umn.edu commits

On Wed, Apr 21, 2021 at 08:59:34AM -0700, Guenter Roeck wrote:
> On 4/21/21 8:21 AM, Kangjie Lu wrote:
> 
> > All of the commits sent by my students are in good faith to fix some bugs.


Just to make sure - does that statement cover the following commit?

commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05
Author: Aditya Pakki <pakki001@....edu>
Date:   Tue Apr 6 19:09:12 2021 -0500

    net/rds: Avoid potential use after free in rds_send_remove_from_sock

And is "Ph.D. student in Computer Science" an accurate description of
the gentleman in question?

We all made utterly bonehead mistakes (if you want a fresh example
of mine, take a look at 161aff1d93ab "LOOKUP_MOUNTPOINT: fold
path_mountpointat() into path_lookupat()"; see 035d80695fae for the
merge of the fix and explanation of what was wrong in the original
commit).

However, there's a general expectation that once you become aware of
dumb mistake in something you have published (and merge into mainline
certainly qualifies as publication) you shall retract it as soon
as possible.  If a student is not aware of such expectation, their
advisor really ought to inform them of it.