linux-kernel - Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210421224859.GA1750844@robh.at.kernel.org>
Date:   Wed, 21 Apr 2021 17:48:59 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jens Wiklander <jens.wiklander@...aro.org>
Cc:     Nishanth Menon <nm@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to
 json schema

On Tue, Apr 20, 2021 at 10:32:37AM +0200, Jens Wiklander wrote:
> On Sat, Apr 17, 2021 at 12:25 AM Nishanth Menon <nm@...com> wrote:
> >
> > Convert linaro,optee-tz to json schema format for better documentation
> > and error checks.
> >
> > NOTE:
> > 1. This change does introduce a stricter naming convention for
> >    optee nodes.
> > 2. We do have false positive checkpatch warning with this patch:
> >    "DT binding docs and includes should be a separate patch"
> >
> > Signed-off-by: Nishanth Menon <nm@...com>
> > ---
> >  .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ----------
> >  .../arm/firmware/linaro,optee-tz.yaml         | 62 +++++++++++++++++++
> >  2 files changed, 62 insertions(+), 31 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> >  create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> > deleted file mode 100644
> > index d38834c67dff..000000000000
> > --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> > +++ /dev/null
> > @@ -1,31 +0,0 @@
> > -OP-TEE Device Tree Bindings
> > -
> > -OP-TEE is a piece of software using hardware features to provide a Trusted
> > -Execution Environment. The security can be provided with ARM TrustZone, but
> > -also by virtualization or a separate chip.
> > -
> > -We're using "linaro" as the first part of the compatible property for
> > -the reference implementation maintained by Linaro.
> > -
> > -* OP-TEE based on ARM TrustZone required properties:
> > -
> > -- compatible     : should contain "linaro,optee-tz"
> > -
> > -- method         : The method of calling the OP-TEE Trusted OS. Permitted
> > -                   values are:
> > -
> > -                   "smc" : SMC #0, with the register assignments specified
> > -                          in drivers/tee/optee/optee_smc.h
> > -
> > -                   "hvc" : HVC #0, with the register assignments specified
> > -                          in drivers/tee/optee/optee_smc.h
> > -
> > -
> > -
> > -Example:
> > -       firmware {
> > -               optee {
> > -                       compatible = "linaro,optee-tz";
> > -                       method = "smc";
> > -               };
> > -       };
> > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> > new file mode 100644
> > index 000000000000..6513b5ac8b2c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> > @@ -0,0 +1,62 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/firmware/linaro,optee-tz.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> 
> Are these links supposed to work?

Could possibly some day, but no. Just convention for json-schema.

Rob