linux-kernel - Re: [PATCH v1] net: Qcom WWAN control driver: fix the rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZdPi9pqS15ABWMpGOZ35-wvfGL4z=NRMrN_Az3nZvmmEKSWQ@mail.gmail.com>
Date:   Wed, 21 Apr 2021 08:46:08 +0200
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Jarvis Jiang <jarvis.w.jiang@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] net: Qcom WWAN control driver: fix the rx_budget was
 eaten incorrectly

Hi Jarvis,

On Wed, 21 Apr 2021 at 05:57, Jarvis Jiang <jarvis.w.jiang@...il.com> wrote:
>
> mhi_wwan_rx_budget_dec() should check the value of mhiwwan->rx_budget
> before the decrement, not the value after decrement.
>
> When mhiwwan->rx_budget = 1, mhi_wwan_rx_budget_dec() will always return
> false, which will cause the mhi_wwan_ctrl_refill_work() not to queue rx
> buffers to transfer ring any more, and rx will be stuck.
>
> This patch was tested with Ubuntu 20.04 X86_64 PC as host
>
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@...il.com>

Thanks for the patch, but a similar change for this issue has just
been merged in net-next (a926c025d56b net: wwan: mhi_wwan_ctrl: Fix RX
buffer starvation).

Regards,
Loic