linux-kernel - Re: [PATCH v9 2/8] mm,memory_hotplug: Relax fully spanned sections check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 09:37:44 +0200
From:   Oscar Salvador <osalvador@...e.de>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/8] mm,memory_hotplug: Relax fully spanned sections
 check

On Tue, Apr 20, 2021 at 11:40:50AM +0200, Michal Hocko wrote:
> On Fri 16-04-21 13:24:05, Oscar Salvador wrote:
> > When using self-hosted vmemmap pages, the number of pages passed to
> > {online,offline}_pages might not fully span sections, but they always
> > fully span pageblocks.
> > Relax the check account for that case.
> 
> It would be good to call those out explicitly.  It would be also
> great to explain why pageblock_nr_pages is an actual constrain. There
> shouldn't be any real reason for that except for "we want online_pages
> to operate on whole memblocks and memmap_on_memory will poke
> pageblock_nr_pages aligned holes in the beginning which is a special
> case we want to allow."

Sounds good.

> 
> > Signed-off-by: Oscar Salvador <osalvador@...e.de>
> > Reviewed-by: David Hildenbrand <david@...hat.com>
> 
> With the changelog extended and the comment clarification (se below)
> feel free to add

Ok, thanks for the suggestion Michal.

> Acked-by: Michal Hocko <mhocko@...e.com>

-- 
Oscar Salvador
SUSE L3